54 lines
2.3 KiB
Diff
54 lines
2.3 KiB
Diff
From dc6909b49ff16af43ac29ce1e61265be33a3bf28 Mon Sep 17 00:00:00 2001
|
|
From: chavacava <salvadorcavadini+github@gmail.com>
|
|
Date: Mon, 1 May 2023 10:30:48 +0200
|
|
Subject: [PATCH] fix tests not passing after the modif of the default rules
|
|
list (#817)
|
|
|
|
---
|
|
revivelib/core_test.go | 17 +++++++----------
|
|
1 file changed, 7 insertions(+), 10 deletions(-)
|
|
|
|
diff --git a/revivelib/core_test.go b/revivelib/core_test.go
|
|
index aa0ddb48..44ab6276 100644
|
|
--- a/revivelib/core_test.go
|
|
+++ b/revivelib/core_test.go
|
|
@@ -26,17 +26,12 @@ func TestReviveLint(t *testing.T) {
|
|
failureList = append(failureList, failure)
|
|
}
|
|
|
|
- const expected = 3
|
|
+ const expected = 5
|
|
|
|
got := len(failureList)
|
|
if got != expected {
|
|
t.Fatalf("Expected failures to have %d failures, but it has %d.", expected, got)
|
|
}
|
|
-
|
|
- errmsg := "redundant if ...; err != nil check, just return error instead."
|
|
- if failureList[0].Failure != errmsg {
|
|
- t.Fatalf("Expected failure[0] to be '%s', but it was '%s'", errmsg, failureList[0].Failure)
|
|
- }
|
|
}
|
|
|
|
func TestReviveFormat(t *testing.T) {
|
|
@@ -57,13 +52,15 @@ func TestReviveFormat(t *testing.T) {
|
|
}
|
|
|
|
errorMsgs := []string{
|
|
- "(15, 2) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
- "(88, 3) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
- "(95, 3) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
+ "(91, 3) https://revive.run/r#unreachable-code unreachable code after this statement",
|
|
+ "(98, 3) https://revive.run/r#unreachable-code unreachable code after this statement",
|
|
+ "(15, 2) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
+ "(88, 3) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
+ "(95, 3) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
}
|
|
for _, errorMsg := range errorMsgs {
|
|
if !strings.Contains(failures, errorMsg) {
|
|
- t.Fatalf("Expected formatted failures '%s' to contain '%s', but it didn't.", failures, errorMsg)
|
|
+ t.Fatalf("Expected formatted failures\n'%s'\nto contain\n'%s', but it didn't.", failures, errorMsg)
|
|
}
|
|
}
|
|
|