From 7b980e56b23311924df83e5807a8713cadc2a25a Mon Sep 17 00:00:00 2001 From: Nathan Owens Date: Mon, 31 Dec 2018 22:04:29 -0600 Subject: [PATCH] libmowgli: fix memory leak --- .../libmowgli/patches/fix-memory-leak.patch | 28 +++++++++++++++++++ srcpkgs/libmowgli/template | 4 +-- 2 files changed, 30 insertions(+), 2 deletions(-) create mode 100644 srcpkgs/libmowgli/patches/fix-memory-leak.patch diff --git a/srcpkgs/libmowgli/patches/fix-memory-leak.patch b/srcpkgs/libmowgli/patches/fix-memory-leak.patch new file mode 100644 index 00000000000..0ac657c1097 --- /dev/null +++ b/srcpkgs/libmowgli/patches/fix-memory-leak.patch @@ -0,0 +1,28 @@ +From 21658b28f1323f11f1aac936b39fb41502c17b8a Mon Sep 17 00:00:00 2001 +From: Aaron Jones +Date: Tue, 6 Mar 2018 19:51:04 +0000 +Subject: [PATCH] src/libmowgli/dns/evloop_res.c: fix memory leak + +mowgli_dns_evloop_init() [called by mowgli_dns_create()] allocates +a random number generator and assigns it to `dns->state->rand', but +mowgli_dns_evloop_destroy() [called by mowgli_dns_destroy()] does +not free this object. + +This was found while running Atheme IRC Services (atheme/#621) under +Valgrind. +--- + src/libmowgli/dns/evloop_res.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/src/libmowgli/dns/evloop_res.c b/src/libmowgli/dns/evloop_res.c +index c8c7775..88757aa 100644 +--- src/libmowgli/dns/evloop_res.c ++++ src/libmowgli/dns/evloop_res.c +@@ -194,6 +194,7 @@ mowgli_dns_evloop_destroy(mowgli_dns_t *dns) + + mowgli_timer_destroy(state->eventloop, state->timeout_resolver_timer); + ++ mowgli_object_unref(state->rand); + mowgli_free(state); + dns->dns_state = NULL; + } diff --git a/srcpkgs/libmowgli/template b/srcpkgs/libmowgli/template index fbc16acbdb0..f790d829176 100644 --- a/srcpkgs/libmowgli/template +++ b/srcpkgs/libmowgli/template @@ -1,15 +1,15 @@ # Template file for 'libmowgli' pkgname=libmowgli version=2.1.3 -revision=4 +revision=5 wrksrc="${pkgname}-2-${version}" build_style=gnu-configure hostmakedepends="pkg-config" makedepends="libressl-devel" short_desc="Performance and usability-oriented extensions to C" maintainer="Juan RP " -homepage="https://github.com/atheme/libmowgli-2" license="MIT" +homepage="https://github.com/atheme/libmowgli-2" distfiles="https://github.com/atheme/libmowgli-2/archive/v${version}.tar.gz" checksum=b7faab2fb9f46366a52b51443054a2ed4ecdd04774c65754bf807c5e9bdda477